• @[email protected]OP
    link
    fedilink
    English
    1616 days ago

    Consistency is NOT the most important thing. Correctness is.

    What point do you think you’re making? I mean, do you think anyone looks at a PR and says “this PR is clearly wrong, but it’s so consistent that I must approve it.” That’s obviously not the point, is it?

    • @[email protected]
      link
      fedilink
      115 days ago

      I’ve definitely seen “this is more correct, but all the other code does it like this so can you change it?”

      I can’t say I entirely disagree with it either - usually the “more correct” is not “the existing code doesn’t work at all”, and keeping it consistent makes it easier to fix all of the code later, because you’re only fixing one style instead of two (or more).