I’m kind of bummed no one at my job really does code reviews seriously. I don’t really get any feedback, so it’s hard to improve.
That’s also probably why the older code is an idiosyncratic mess of mutations and "oh yeah you need this config file that’s not in source control " and “oh sorry I guess I hard coded that file path, huh?”
Exactly the same at my job. And it really shows in the code quality, or lack thereof. And then sometimes they wonder why it becomes more and more complicated to add new things. But most of the time they just think that it’s perfectly normal that way and are completely oblivious to all the ways it could be improved. I once talked to my boss about it and he basically replied with “Well you know, there just isn’t a code style that everybody likes, so there’s no reason to even try.”
I’ve been pushing to add some basic checks on PR, and people are reluctant. There’s one repo that I’m code owner on so I spent the like 15 minutes to apply a code formatter and add a GitHub action to check. But on the main repo people are dragging their heels. I’m like just pick ruff or black and do it. It’s going to take like 10 minutes. I’m not asking for us to go crazy and add automated tests right now, but can we at least get something to verify the python code is syntactically correct?
The other day something went through code review until I looked at it and saw there was an extra
(, and that shit wouldn’t even run. I’m like please please add an automated check. I’ll do it. Please.I think a lot of people just aren’t familiar with how other places do software. This is the same place that was ssh’ing into prod and making changes right on the machine until like this month.
Never let perfection be the enemy of getting it to work.
I can improve it later™
When doing pr reviews, I often also shrug and think: “If it breaks, it’s not my mess to clean up.” Then click Aporoved.
lgtm
Let’s gamble, try merging!
nice
Nice, I’m using this
Spoiler alert: is own code 😔
